Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-13513 (ios) Declare ProvisioningStyle as Automatic in project.pbxproj template. #343

Merged
merged 2 commits into from
Jan 18, 2018
Merged

CB-13513 (ios) Declare ProvisioningStyle as Automatic in project.pbxproj template. #343

merged 2 commits into from
Jan 18, 2018

Conversation

paulussup
Copy link
Contributor

@paulussup paulussup commented Oct 7, 2017 •
edited
Loading

Platforms affected

IOS

What does this PR do?

Declares ProvisioningStyle in project.pbxproj to allow fastlane to turn off automatic code signing which appears to default to Automatic.

What testing has been done on this change?

Built App and successfully updated signing to Manual

Checklist

  • [ x] Reported an issue in the JIRA database
  • [ x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files          14       14           
  Lines        1690     1690           
  Branches      283      283           
=======================================
  Hits         1072     1072           
  Misses        618      618

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7964f...5f2de97. Read the comment docs.

@joshstrange joshstrange mentioned this pull request Oct 11, 2017
Closed
@bartvollebregt
Copy link

I'm experiencing problems because of this issue. Would love to see this merged as soon as possible.

@janpio
Copy link
Member

janpio commented Oct 16, 2017

What exactly is the issue? The PR doesn't reference a Cordova issue.

If this really is about fastlane usage, then I are right now putting the finishing touches on a fastplane plugin to add these TargetAttributes. Will be called fastlane-plugin-upgrade_super_old_xcode, watch that repo for a release soon-ish.

@shazron
Copy link
Member

shazron commented Oct 30, 2017

Please file an issue in issues.cordova.io and add it as a prefix to the title, as the PR template required when you opened this PR (it's in the checklist).

@paulussup paulussup changed the title Declare ProvisioningStyle as Automatic in project.pbxproj template. CB-13513 (ios) Declare ProvisioningStyle as Automatic in project.pbxproj template. Oct 31, 2017
@purplecabbage purplecabbage merged commit fa41ae3 into apache:master Jan 18, 2018
@yechenchao
Copy link

This PR is very helpful, but the changes seem not to be appear in cordova-ios 4.5.5, what is happening?

@brodycj
Copy link
Contributor

brodycj commented Nov 25, 2018

This change will be in the next major release.

We could make a 4.5.6 patch release with this change, don't know if any members will have time to do this and wonder if this could be a breaking change for anyone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@paulussup @codecov-io @bartvollebregt @janpio @shazron @yechenchao @brodycj @purplecabbage